• src/syncterm/term.c

    From Deucе@VERT to Git commit to main/sbbs/master on Sun Dec 25 14:09:03 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/cd3a3a2d9f5b63b722194c80
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix b64 decode buf length calculation

    Previously, b64_decode was being asked to decode past the end of
    the application string.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Dec 28 19:54:31 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/29eb84a9762d210550e54c0e
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Since we have the code to generate the correct gamma transfer, let's
    not scale it in one colour space before translating it to a different
    one.

    Also, since almost all PPMs will use a maxval of 255, compile that
    in as the default so we don't need to generate it.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Dec 28 20:21:12 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/6cfed436084fb6acf5591e7e
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Initialize pointer to NULL to avoid free()ing unallocated memory.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Dec 28 20:22:50 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/fafed094c52b0ca167e6fd51
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Initialize mbuf too.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Mar 29 12:40:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/7aa6f21e42f94ff7807279a5
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Resolve GCC 12.2 warnings

    warning: format ‘%s’ expects argument of type ‘char *’, but argument 4 has type ‘void *’
    warning: ‘sprintf’ writing a terminating nul past the end of the destination

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Apr 21 13:50:36 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d0650fbaeb167af68d51d2bf
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Perform unicode-to-codepage for US-ASCII input

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Apr 21 13:53:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/79831364263801c9e3a6141d
    Modified Files:
    src/syncterm/term.c
    Log Message:
    include <math.h> for pow()

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Wed May 31 21:33:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/12eb94e24a34dee6eea938db
    Modified Files:
    src/syncterm/term.c
    Log Message:
    warning: pointer targets in passing argument 1 of ‘strcmp’ differ in signedness

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Jun 5 16:54:36 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/a47f94b80878b4d6597234a6
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix GCC v12.2.0 -O1 warnings

    warning: ‘maxval’ may be used uninitialized
    warning: ‘inch’ may be used uninitialized

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Sep 29 17:47:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/93a8c94862d8c76146460413
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix bug generating SAUCE date introduced by commit dcf8c35f9b

    Using snprintf() prevents the last character of the date from
    being put into the string.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Sep 29 18:10:09 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/829c5009fcfb0b2c5be5eac2
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix last commit.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Sep 30 19:53:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/02460447d3eaa1f1532229e4
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix SAUCE date properly... avoid writing past the end of the buffer

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Oct 23 09:38:38 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f25fafae6c6cc27761998909
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix some remains of input weirdness...

    Now that the conio layer is handling translation of character sets,
    the key handler in term.c should only handle terminal related
    translations (such as backspace to delete).

    This fixes bug 159, but there's still some inconsistency across
    the various backends on how they handle C0 control characters and
    input characters outside of US-ASCII.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Nov 3 01:40:35 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b50d96f6f771017444853a31
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Make Return send #, use CTRL-Return for return

    Not tested on Windows.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Nov 3 01:49:08 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/774d285494551046a4e73ec8
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Map underscore to pound

    I think this map may be the final one.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 28 10:13:12 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2132c3f3d4af3b3fe85029fa
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix MD5 calculation for cache files over 32k

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 28 14:29:23 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/77376487d3dac208e29012f2
    Modified Files:
    src/syncterm/term.c
    Log Message:
    At least make the comments correctish.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 28 16:35:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f6a44d1477cfede0e65d6489
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Properly handle the case where libjxl thread support is missing

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Dec 29 12:07:05 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e3241a522e3af5f5171e4917
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix typo in lazy "fix"

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Dec 30 17:22:56 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c56c9d9032c033ccc81651bd
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Convert ^G back to 7 when sent.

    This technically fixes issue 137 which specifically asked for
    "backslash", but backspace (^H) and tab (^I) along with CR (^M)
    still do a different thing than they do on Atari keyboards.

    Further, CTRL-Q and CTRL-S are used by SyncTERM for Quit and Menu
    respectively, so someone expecting all the Atari "stuff" to work
    will still be disappointed.

    This is a general problem with non-PC emulation (ie: Prestel, Atari,
    and Commodore) that really needs some kind of general solution.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 3 00:32:32 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b9333a0b4f9be867f964b278
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Another attempt to silence Coverity.

    This may be the first time in my life that I've used difftime()...
    which is strictly one of only two things you're actually allowed
    to do with a time_t per the C standard (the other is convert into
    a broken-down time).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 3 13:47:12 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ba945f3c202ec0c320944c52
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Try to tell Coverity that getch() isn't constant.

    I'm not sure if I can do this with events, or just issues, and I
    don't want to directly annotate this issue because that could lead
    to missing an issue after a future code change.

    The return value of getch() will never be const though.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Jan 3 14:14:08 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/cdca88a29a653607fa5babd6
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Actually, mark this as suppress since I would like this one to go away

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Jan 8 16:33:58 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/1fe1adc1757d2e778d57044d
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Don't fiddle with the status bar fonts if we're not going to update it.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Jan 9 08:32:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/430629d878abb64bc7f852b7
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Let time get big enough to be too big

    Previous commit capped it too early.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Jan 12 11:52:06 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/3c9e6b01e1a15486dfacdb32
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Don't sleep() after receiving input.

    2.1 seconds.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Jan 12 12:13:57 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/9ab17ee464c2f66b5570863a
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Don't egregiously use strlen() for ZRQ and OOII buffers.

    We're building these one byte at a time, we know the length.
    1.98s

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Jan 27 09:08:14 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/855af348ce4a9b189aa553aa
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Fix legacy attributes when redrawing status bar

    legacy_attr is the CGA attribute, not ANSI colours. :D
    Fixes ticket 183.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Jan 28 17:15:28 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/985cc21745ba1a7c166c31d8
    Modified Files:
    src/syncterm/term.c
    Log Message:
    Send login info in a single conn_send() call

    Should "fix" the timing difference in login info between modes.
    This removes a 10ms SLEEP() between the different pieces of data,
    and would likely have resolved ticket 185 if it wasn't already
    closed.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net